Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Issue 2128773002: cc: Do not verify resource sync tokens unnecessarily. (Closed)

Created:
4 years, 5 months ago by sunnyps
Modified:
4 years, 5 months ago
Reviewers:
piman
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Do not verify resource sync tokens unnecessarily. ResourceProvider::delegated_sync_points_required_ and ResourceProvider::Child::needs_sync_tokens only toggle the creation of sync tokens by ResourceProvider but ResourceProvider always tries to verify sync tokens already associated with resources e.g. from the worker thread. This CL ensures that we don't verify sync tokens if those flags are off. R=piman@chromium.org BUG=626193 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/91978e02d9bd4c39d10de4a2a1698742d50b3ffb Cr-Commit-Position: refs/heads/master@{#404435}

Patch Set 1 #

Patch Set 2 : set sync token after verification #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -56 lines) Patch
M cc/resources/resource_provider.cc View 1 6 chunks +66 lines, -56 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
sunnyps
PTAL
4 years, 5 months ago (2016-07-07 01:37:37 UTC) #2
sunnyps
Setting the sync token (for resources which didn't have sync tokens) before verification was causing ...
4 years, 5 months ago (2016-07-07 22:38:03 UTC) #3
piman
lgtm
4 years, 5 months ago (2016-07-07 23:00:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2128773002/20001
4 years, 5 months ago (2016-07-08 17:25:12 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-08 18:04:03 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 18:04:23 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 18:06:58 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/91978e02d9bd4c39d10de4a2a1698742d50b3ffb
Cr-Commit-Position: refs/heads/master@{#404435}

Powered by Google App Engine
This is Rietveld 408576698