components/autofill/core/browser/webdata/autofill_profile_syncable_service.h - Issue 212873003: Store the language code for the address in autofill profile.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/webdata/autofill_profile_syncable_service.h

Issue 212873003: Store the language code for the address in autofill profile. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/core/browser/autofill_profile.cc ('K') | « components/autofill/core/browser/personal_data_manager_unittest.cc ('k') | components/autofill/core/browser/webdata/autofill_profile_syncable_service.cc » ('j') | components/autofill/core/browser/webdata/autofill_profile_syncable_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/webdata/autofill_profile_syncable_service.h

diff --git a/components/autofill/core/browser/webdata/autofill_profile_syncable_service.h b/components/autofill/core/browser/webdata/autofill_profile_syncable_service.h

index a29ff4fd701894dc7826c611f92e5f47d329fd44..715b40c8316d52542f78d769d2acc1e89f8a4a35 100644

--- a/components/autofill/core/browser/webdata/autofill_profile_syncable_service.h

+++ b/components/autofill/core/browser/webdata/autofill_profile_syncable_service.h

@@ -176,8 +176,7 @@ class AutofillProfileSyncableService

// Calls merge_into->OverwriteWithOrAddTo() and then checks if the

- // multi-valued field values that are not in |merge_from| or if the origins

- // of the two profiles differ, false otherwise.

+ // multi-valued field values that are not in |merge_from|.

// TODO(isherman): Seems like this should return |true| if |merge_into| was

// modified at all: http://crbug.com/248440

static bool MergeProfile(const AutofillProfile& merge_from,