Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2942)

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_i18n_input_unittest.cc

Issue 212873003: Store the language code for the address in autofill profile. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_dialog_i18n_input_unittest.cc
diff --git a/chrome/browser/ui/autofill/autofill_dialog_i18n_input_unittest.cc b/chrome/browser/ui/autofill/autofill_dialog_i18n_input_unittest.cc
index a78db232e139479825e985aca2d7a837749ce61c..f7cd71aa9dae441102b37d917b9a1671fb2c8808 100644
--- a/chrome/browser/ui/autofill/autofill_dialog_i18n_input_unittest.cc
+++ b/chrome/browser/ui/autofill/autofill_dialog_i18n_input_unittest.cc
@@ -23,16 +23,21 @@ const size_t kNumberOfAddressLinesUS = 6;
TEST(AutofillDialogI18nInput, USShippingAddress) {
DetailInputs inputs;
- BuildAddressInputs(common::ADDRESS_TYPE_SHIPPING, "US", &inputs);
+ std::string language_code;
+ BuildAddressInputs(common::ADDRESS_TYPE_SHIPPING, "US", &inputs,
+ &language_code);
ASSERT_EQ(kNumberOfAddressLinesUS, inputs.size());
EXPECT_EQ(NAME_FULL, inputs[0].type);
EXPECT_EQ(ADDRESS_HOME_COUNTRY, inputs[kNumberOfAddressLinesUS - 1].type);
+ EXPECT_EQ("en", language_code);
}
TEST(AutofillDialogI18nInput, USBillingAddress) {
DetailInputs inputs;
- BuildAddressInputs(common::ADDRESS_TYPE_BILLING, "US", &inputs);
+ std::string language_code;
+ BuildAddressInputs(common::ADDRESS_TYPE_BILLING, "US", &inputs,
+ &language_code);
Ilya Sherman 2014/03/29 01:24:42 nit: Might as well either pass NULL or verify the
please use gerrit instead 2014/04/02 21:54:52 Done.
ASSERT_EQ(kNumberOfAddressLinesUS, inputs.size());
EXPECT_EQ(NAME_BILLING_FULL, inputs[0].type);
@@ -41,7 +46,7 @@ TEST(AutofillDialogI18nInput, USBillingAddress) {
TEST(AutofillDialogI18nInput, USCityStateAndZipCodeShareInputRow) {
DetailInputs inputs;
- BuildAddressInputs(common::ADDRESS_TYPE_SHIPPING, "US", &inputs);
+ BuildAddressInputs(common::ADDRESS_TYPE_SHIPPING, "US", &inputs, NULL);
ASSERT_EQ(kNumberOfAddressLinesUS, inputs.size());
#if defined(OS_MACOSX)
@@ -70,10 +75,13 @@ TEST(AutofillDialogI18nInput, USCityStateAndZipCodeShareInputRow) {
TEST(AutofillDialogI18nInput, IvoryCoastNoStreetLine2) {
DetailInputs inputs;
- BuildAddressInputs(common::ADDRESS_TYPE_SHIPPING, "CI", &inputs);
+ std::string language_code;
+ BuildAddressInputs(common::ADDRESS_TYPE_SHIPPING, "CI", &inputs,
+ &language_code);
for (size_t i = 0; i < inputs.size(); ++i) {
EXPECT_NE(ADDRESS_HOME_LINE2, inputs[i].type);
}
+ EXPECT_EQ("fr", language_code);
}
TEST(AutofillDialogI18nInput, FullySupportedCountries) {

Powered by Google App Engine
This is Rietveld 408576698