LayoutTests/editing/selection/contains-node-cleared-document.html - Issue 212873002: Remove Selection.containsNode assertion that is not valid.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/editing/selection/contains-node-cleared-document.html

Issue 212873002: Remove Selection.containsNode assertion that is not valid. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Make test slightly smaller. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: LayoutTests/editing/selection/contains-node-cleared-document.html

diff --git a/LayoutTests/editing/selection/contains-node-crash.html b/LayoutTests/editing/selection/contains-node-cleared-document.html

similarity index 60%

copy from LayoutTests/editing/selection/contains-node-crash.html

copy to LayoutTests/editing/selection/contains-node-cleared-document.html

index ef0c04e93af34a058a72216d71b5fe1b4055acda..4638da14ee60ff2d34f0538c2f77df245bf311e2 100644

--- a/LayoutTests/editing/selection/contains-node-crash.html

+++ b/LayoutTests/editing/selection/contains-node-cleared-document.html

@@ -1,5 +1,4 @@

-<!DOCTYPE html>

-<html style="display: inline-table">

+<html>

if (window.testRunner)

testRunner.dumpAsText();

@@ -9,10 +8,13 @@ window.onload = function() {

selection.selectAllChildren(document);

selection.collapseToEnd();

var element = document.activeElement;

+ var parent = element.parentNode;

Yuta Kitamura 2014/03/27 01:21:12 |parent| is not used; is this necessary?

Mads Ager (chromium) 2014/03/27 13:52:44 Yes, that is actually what is causing the issue he

document.open();

- document.write("Pass. Test didn't crash.");

+ if (selection.containsNode(element,true))

Yuta Kitamura 2014/03/27 01:21:12 nit: space after comma

Mads Ager (chromium) 2014/03/27 13:52:44 Thanks, done.

+ document.write("FAIL: selection.containsNode should return false");

+ else

+ document.write("PASS");

document.close();

- selection.containsNode(element,true);

}

</script>

</html>