Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2128703002: MD Settings: add "Use system title bar and borders" (Closed)

Created:
4 years, 5 months ago by Dan Beam
Modified:
4 years, 5 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, dbeam+watch-options_chromium.org, extensions-reviews_chromium.org, michaelpg+watch-options_chromium.org, michaelpg+watch-md-settings_chromium.org, tfarina, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, chromium-apps-reviews_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: add "Use system title bar and borders" Also, shuffle around how some strings and logic work. We really only support removing window decorations on desktop Linux. R=thestig@chromium.org BUG=624194 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/5acada556e627b6c3aceddd38fc9d9702d8d453a Cr-Commit-Position: refs/heads/master@{#404025}

Patch Set 1 : more stragglers #

Patch Set 2 : fix windoze compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -21 lines) Patch
M chrome/app/chrome_command_ids.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/generated_resources.grd View 2 chunks +2 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/settings_private/prefs_util.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/browser_options.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/appearance_page/appearance_page.html View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_view_prefs.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/frame/system_menu_model_delegate.cc View 1 2 chunks +11 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Dan Beam
4 years, 5 months ago (2016-07-06 22:06:28 UTC) #3
Lei Zhang
Your trybots are red.
4 years, 5 months ago (2016-07-06 22:22:00 UTC) #4
Dan Beam
On 2016/07/06 22:22:00, Lei Zhang wrote: > Your trybots are red. fixted them!
4 years, 5 months ago (2016-07-07 00:14:11 UTC) #5
Lei Zhang
lgtm
4 years, 5 months ago (2016-07-07 00:22:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2128703002/40001
4 years, 5 months ago (2016-07-07 00:39:46 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 5 months ago (2016-07-07 00:46:02 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 00:46:18 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 00:48:45 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5acada556e627b6c3aceddd38fc9d9702d8d453a
Cr-Commit-Position: refs/heads/master@{#404025}

Powered by Google App Engine
This is Rietveld 408576698