Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 2128693002: fix code completion when enableTrailingCommas is true (Closed)

Created:
4 years, 5 months ago by danrubel
Modified:
4 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -3 lines) Patch
M pkg/analysis_server/lib/src/provisional/completion/dart/completion_target.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/arglist_contributor.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/optype.dart View 1 chunk +13 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_target_test.dart View 2 chunks +21 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
4 years, 5 months ago (2016-07-06 21:30:11 UTC) #2
Brian Wilkerson
lgtm
4 years, 5 months ago (2016-07-06 21:33:39 UTC) #3
danrubel
4 years, 5 months ago (2016-07-07 16:42:42 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
37a6f6256680d2f7e948a43d7da82baaabf45d65 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698