Pull out freelist allocation from GrVkSubHeap

Pull out freelist allocation from GrVkSubHeap

BUG=skia:5031
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2128673002

Committed: https://skia.googlesource.com/skia/+/82356cc41f360c607a1612cb9aead2423c0846a0

[jvanverth1, 2016-07-06 20:10:17]

Description was changed from

==========
Pull out freelist allocation from GrVkSubHeap

BUG=skia:5031
==========

to

==========
Pull out freelist allocation from GrVkSubHeap

BUG=skia:5031
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2128673002
==========

[jvanverth1, 2016-07-06 20:22:34]

jvanverth@google.com changed reviewers:
+ bsalomon@google.com, egdaniel@google.com

[jvanverth1, 2016-07-06 20:22:34]

This is a stepping stone to suballocating buffers (I'll be subclassing
GrVkFreeListAlloc).

[bsalomon, 2016-07-07 13:29:01]

lgtm

[jvanverth1, 2016-07-07 13:58:54]

The CQ bit was checked by jvanverth@google.com

[commit-bot: I haz the power, 2016-07-07 13:59:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 14:16:45]

Description was changed from

==========
Pull out freelist allocation from GrVkSubHeap

BUG=skia:5031
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2128673002
==========

to

==========
Pull out freelist allocation from GrVkSubHeap

BUG=skia:5031
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2128673002

Committed:
https://skia.googlesource.com/skia/+/82356cc41f360c607a1612cb9aead2423c0846a0
==========

[commit-bot: I haz the power, 2016-07-07 14:16:45]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/82356cc41f360c607a1612cb9aead2423c0846a0

[rmistry, 2016-07-07 14:34:18]

On 2016/07/07 14:16:45, commit-bot: I haz the power wrote:
> Committed patchset #2 (id:20001) as
> https://skia.googlesource.com/skia/+/82356cc41f360c607a1612cb9aead2423c0846a0

Looks like this called the vulcan compile bot to fail:


FAILED: /usr/bin/ccache
/b/work/skia/platform_tools/android/bin/../toolchains/arm-r11c-24/bin/arm-linux-androideabi-g++
-MMD -MF obj/src/gpu/vk/skgpu.GrVkMemory.o.d -DSK_INTERNAL
-DSK_GAMMA_APPLY_TO_A8 -DQT_NO_KEYWORDS -DSK_ALLOW_STATIC_GLOBAL_INITIALIZERS=0
-DSK_SUPPORT_GPU=1 -DSK_FORCE_DISTANCE_FIELD_TEXT=0 -DSK_HAS_GIF_LIBRARY
-DSK_HAS_JPEG_LIBRARY -DSK_HAS_PNG_LIBRARY -DSK_HAS_WEBP_LIBRARY -DSK_TEST_QCMS
-DSK_VULKAN -DSK_IS_BOT -DSK_CODEC_DECODES_RAW -DSK_ARM_HAS_NEON
-DSK_BUILD_FOR_ANDROID -DSK_GAMMA_EXPONENT=1.4 -DSK_GAMMA_CONTRAST=0.0
-DSKIA_DLL -DSKIA_IMPLEMENTATION=1 -DSK_SUPPORT_LEGACY_CLIPTOLAYERFLAG
-DGR_CHROME_UTILS=1 -DGR_GL_USE_NEW_SHADER_SOURCE_SIGNATURE=1 -DSK_DEBUG=1
-I../../../include/gpu -I../../../include/private -I../../../src/core
-I../../../src/gpu -I../../../src/image -I../../../src/sksl -I../../../include/c
-I../../../include/config -I../../../include/core -I../../../include/pathops
-I../../../include/utils -I../../../src/utils -I../../../third_party/etc1
-I../../../third_party/ktx
-I../../../third_party/externals/shaderc2/libshaderc/include -fPIC -g
-fno-exceptions -fstrict-aliasing -Wall -Wextra -Winit-self -Wpointer-arith
-Wsign-compare -Wvla -Wno-unused-parameter -Werror -march=armv7-a -mthumb
-mfpu=neon -mfloat-abi=softfp -fuse-ld=gold -std=c++11 -fno-rtti
-fno-threadsafe-statics -Wnon-virtual-dtor  -c
../../../src/gpu/vk/GrVkMemory.cpp -o obj/src/gpu/vk/skgpu.GrVkMemory.o
../../../src/gpu/vk/GrVkMemory.cpp: In member function 'bool
GrVkFreeListAlloc::alloc(VkDeviceSize, VkDeviceSize*, VkDeviceSize*)':
../../../src/gpu/vk/GrVkMemory.cpp:323:26: error: ordered comparison of pointer
with integer zero [-Werror=extra]
         SkASSERT(allocSize > 0);
                          ^
cc1plus: all warnings being treated as errors
ninja: build stopped: subcommand failed.
step returned non-zero exit code: 1
@@@STEP_FAILURE@@@



Complete build is here:
https://uberchromegw.corp.google.com/i/client.skia.compile/builders/Build-Ubu...