Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Issue 2128633004: [Cronet] Don't send endOfStream if there is pending data to flush on iOS. (Closed)

Created:
4 years, 5 months ago by mef
Modified:
4 years, 5 months ago
Reviewers:
kapishnikov, xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cronet] Don't send endOfStream if there is pending data to flush on iOS. BUG=623988 Committed: https://crrev.com/a3e2f52dbaabf8769c9e83cf2798f3760ccd7603 Cr-Commit-Position: refs/heads/master@{#404691}

Patch Set 1 #

Patch Set 2 : Added test that fails without change. #

Patch Set 3 : Sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -3 lines) Patch
M components/cronet/ios/cronet_bidirectional_stream.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M components/cronet/ios/test/cronet_bidirectional_stream_test.mm View 1 1 chunk +49 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
mef
PTAL. This also fixes Andrei's comment on initial CL.
4 years, 5 months ago (2016-07-08 16:50:21 UTC) #2
xunjieli
lgtm. Thanks!
4 years, 5 months ago (2016-07-08 20:43:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2128633004/40001
4 years, 5 months ago (2016-07-11 17:40:44 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-11 18:18:20 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-11 18:18:31 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 18:19:40 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a3e2f52dbaabf8769c9e83cf2798f3760ccd7603
Cr-Commit-Position: refs/heads/master@{#404691}

Powered by Google App Engine
This is Rietveld 408576698