tests/PathOpsExtendedTest.h - Issue 2128633003: pathops coincidence and security rewrite

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/PathOpsExtendedTest.h

Issue 2128633003: pathops coincidence and security rewrite (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: require resulting t to be between 0 and 1 Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/PathOpsExtendedTest.h

diff --git a/tests/PathOpsExtendedTest.h b/tests/PathOpsExtendedTest.h

index 1fadeb8ca4d839c3debe3d135f9bf35fecb4e695..f6efbef040d79ec87bc74d63612e7d98337d525f 100644

--- a/tests/PathOpsExtendedTest.h

+++ b/tests/PathOpsExtendedTest.h

@@ -40,19 +40,23 @@ extern bool testPathOp(skiatest::Reporter* reporter, const SkPath& a, const SkPa

const SkPathOp , const char* testName);

extern bool testPathOpCheck(skiatest::Reporter* reporter, const SkPath& a, const SkPath& b,

const SkPathOp , const char* testName, bool checkFail);

+extern bool testPathOpFail(skiatest::Reporter* reporter, const SkPath& a, const SkPath& b,

+ const SkPathOp, const char* testName);

extern bool testPathOpFailCheck(skiatest::Reporter* reporter, const SkPath& a, const SkPath& b,

const SkPathOp , const char* testName);

-extern bool testPathFailOp(skiatest::Reporter* reporter, const SkPath& a, const SkPath& b,

- const SkPathOp , const char* testName);

-extern bool testPathFailSkipAssertOp(skiatest::Reporter* reporter, const SkPath& a, const SkPath& b,

- const SkPathOp , const char* testName);

-extern bool testPathSkipAssertOp(skiatest::Reporter* reporter, const SkPath& a, const SkPath& b,

+extern bool testPathOpFailSkipAssert(skiatest::Reporter* reporter, const SkPath& a, const SkPath& b,

+ const SkPathOp , const char* testName);

+extern bool testPathOpSkipAssert(skiatest::Reporter* reporter, const SkPath& a, const SkPath& b,

const SkPathOp , const char* testName);

extern bool testSimplify(SkPath& path, bool useXor, SkPath& out, PathOpsThreadState& state,

const char* pathStr);

extern bool testSimplify(skiatest::Reporter* reporter, const SkPath& path, const char* filename);

extern bool testSimplifyCheck(skiatest::Reporter* reporter, const SkPath& path,

const char* filename, bool checkFail);

+extern bool testSimplifyFailSkipAssert(skiatest::Reporter* reporter, const SkPath& path,

+ const char* filename);

+extern bool testSimplifySkipAssert(skiatest::Reporter* reporter, const SkPath& path,

+ const char* filename);

void initializeTests(skiatest::Reporter* reporter, const char* testName);

void outputProgress(char* ramStr, const char* pathStr, SkPath::FillType );