src/pathops/SkPathOpsCubic.cpp - Issue 2128633003: pathops coincidence and security rewrite

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/pathops/SkPathOpsCubic.cpp

Issue 2128633003: pathops coincidence and security rewrite (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: require resulting t to be between 0 and 1 Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/pathops/SkPathOpsCubic.cpp

diff --git a/src/pathops/SkPathOpsCubic.cpp b/src/pathops/SkPathOpsCubic.cpp

index a161e368e7da5e44a17d7a47741aefc98841a7ee..7fd3dd235d52762d8fa9514984d18bf7afcb7972 100644

--- a/src/pathops/SkPathOpsCubic.cpp

+++ b/src/pathops/SkPathOpsCubic.cpp

@@ -277,7 +277,7 @@ bool SkDCubic::ComplexBreak(const SkPoint pointsPtr[4], SkScalar* t) {

for (int index = 0; index < roots; ++index) {

if (between(inflectionTs[0], maxCurvature[index], inflectionTs[1])) {

*t = maxCurvature[index];

- return true;

+ return *t > 0 && *t < 1;

}

} else if (infTCount == 1) {