Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 212863007: Modify toolchain.gypi to avoid adding -m64 flag on android. (Closed)

Created:
6 years, 9 months ago by rmcilroy
Modified:
6 years, 9 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Modify toolchain.gypi to avoid adding -m64 flag on android. The -m64 flag isn't supported on Android. Add a similar gyp condition to avoid setting the flag on Android in a similar manner to how the -m32 flag is avoided on android. BUG=354405 LOG=N R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20289

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M build/toolchain.gypi View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rmcilroy
Ulan, ptal. Thanks.
6 years, 9 months ago (2014-03-26 16:42:39 UTC) #1
ulan
lgtm
6 years, 9 months ago (2014-03-26 17:23:40 UTC) #2
rmcilroy
6 years, 9 months ago (2014-03-26 18:23:41 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20289 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698