Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(923)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 212863005: DevTools: Make Array.remove O(N). (Closed)

Created:
6 years, 9 months ago by aandrey
Modified:
6 years, 9 months ago
Reviewers:
alph, pfeldman, yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: Make Array.remove O(N). TEST=LayoutTests/inspector/utilities.html R=alph, pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170068

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M Source/devtools/front_end/utilities.js View 1 chunk +8 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
aandrey
6 years, 9 months ago (2014-03-26 13:41:22 UTC) #1
yurys
lgtm
6 years, 9 months ago (2014-03-26 13:48:40 UTC) #2
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 9 months ago (2014-03-26 13:55:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/212863005/1
6 years, 9 months ago (2014-03-26 13:55:59 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 14:58:22 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-26 14:58:22 UTC) #6
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 9 months ago (2014-03-26 16:06:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/212863005/1
6 years, 9 months ago (2014-03-26 16:07:05 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-26 17:46:07 UTC) #9
Message was sent while issue was closed. 
Change committed as 170068

Powered by Google App Engine
This is Rietveld 408576698