Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 212863004: Revert of content: Avoid duplicating the logic used to determine GPU features. (Closed)

Created:
6 years, 9 months ago by vsevik
Modified:
6 years, 9 months ago
Reviewers:
reveman, piman
CC:
chromium-reviews, creis+watch_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, nasko+codewatch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, James Su, miu+watch_chromium.org
Visibility:
Public.

Description

Revert of content: Avoid duplicating the logic used to determine GPU features. (https://codereview.chromium.org/212003002/) Reason for revert: Breaks webkit_tests on android: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/11175 Original issue's description: > content: Avoid duplicating the logic used to determine GPU features. > > For features that need to be determined if used in the browser, > keep all the logic on browser side rather than duplicating it > in the renderer. > > BUG=354449 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259543 TBR=piman@chromium.org,reveman@chromium.org NOTREECHECKS=true NOTRY=true BUG=354449 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259565

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -13 lines) Patch
M content/browser/gpu/compositor_util.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 7 chunks +9 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/render_widget.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
vsevik
Created Revert of content: Avoid duplicating the logic used to determine GPU features.
6 years, 9 months ago (2014-03-26 13:30:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/212863004/1
6 years, 9 months ago (2014-03-26 13:30:17 UTC) #2
commit-bot: I haz the power
6 years, 9 months ago (2014-03-26 13:31:01 UTC) #3
Message was sent while issue was closed.
Change committed as 259565

Powered by Google App Engine
This is Rietveld 408576698