Issue 212863002: MSan workaround in Simulator::VisitBitfield.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 212863002: MSan workaround in Simulator::VisitBitfield. (Closed)

Created:
6 years, 9 months ago by eugenis

Modified:
6 years, 8 months ago

Reviewers:
danno, Jakob Kummerow

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

MSan workaround in Simulator::VisitBitfield. This change shuffles the code in Simulator::VisitBitfield a bit to work around a MemorySanitizer bug. New code should not be any slower or less readable than before. More info: https://code.google.com/p/memory-sanitizer/issues/detail?id=50 R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20401

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	src/arm64/simulator-arm64.cc	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

eugenis

MSan bug is fixed in LLVM trunk. This change would let us make progress without ...

6 years, 9 months ago (2014-03-26 12:57:41 UTC) #1

Jakob Kummerow

I find both versions hard to read... I guess that counts as "LGTM" :-P I'll ...

6 years, 8 months ago (2014-04-01 12:19:00 UTC) #2

Jakob Kummerow

6 years, 8 months ago (2014-04-01 12:51:20 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r20401 (presubmit successful).