Archive Linux perf builds for manual bisect

scripts/slave/recipe_modules/chromium_tests/api.py

Index: scripts/slave/recipe_modules/chromium_tests/api.py
diff --git a/scripts/slave/recipe_modules/chromium_tests/api.py b/scripts/slave/recipe_modules/chromium_tests/api.py
index d8134af777664f109a751d654f4774dd94b8e7cb..327880d738bf4b72c0f4f2605f8ca659198f879d 100644
--- a/scripts/slave/recipe_modules/chromium_tests/api.py
+++ b/scripts/slave/recipe_modules/chromium_tests/api.py
@@ -430,6 +430,24 @@ class ChromiumTestsApi(recipe_api.RecipeApi):
       if not bot_config.get('cf_archive_build'):
         master_config = bot_db.get_master_settings(mastername)
         build_revision = update_step.presentation.properties['got_revision']
+
+        # For archiving 'chromium.perf', the builder also archives a version
+        # without perf test files for manual bisect.
+        # (https://bugs.chromium.org/p/chromium/issues/detail?id=604452)
+        if (mastername.startswith('chromium.perf') and

[ghost stip (do not use), 2016/08/15 20:12:16]

I'm not comfortable with having an if statement gated on the mastername this
deep in the code. We should set a flag for archive_build() enabling this
behavior (perhaps something like "enable_manual_bisect"), and turn on this
behavior in the recipe itself. I believe this is done with a recipe config.
martiniss@ can help out here for the right way to do it.

[miimnk, 2016/08/15 21:41:22]

If you see recipe_modules/chromium_tests/chromium_perf.py, it contains the SPEC
for running the perf recipes. I previously added a 'bisect_builders' attribute
to the SPEC. We don't need to check the master name because we only need to
check if the SPEC for the master contains 'bisect_builders'.

I removed the "(mastername.startswith('chromium.perf'))" condition as it works
without it. 

+            master_config.get('bisect_builders') is not None and
+            buildername in master_config.get('bisect_builders')):
+          self.m.archive.zip_and_upload_build(
+              'package build for bisect',
+              self.m.chromium.c.build_config_fs,
+              build_url=self._build_bisect_gs_archive_url(master_config),
+              build_revision=build_revision,
+              cros_board=self.m.chromium.c.TARGET_CROS_BOARD,
+              update_properties=update_step.presentation.properties,
+              include_perf_test_files=False,
+              store_by_hash=False
+          )
+
         self.m.archive.zip_and_upload_build(
             'package build',
             self.m.chromium.c.build_config_fs,
@@ -715,6 +733,11 @@ class ChromiumTestsApi(recipe_api.RecipeApi):
     return self.m.chromium_swarming.configure_swarming(  # pragma: no cover
         project_name, precommit, mastername)
 
+  def _build_bisect_gs_archive_url(self, master_config):
+    return self.m.archive.legacy_upload_url(
+        master_config.get('bisect_build_gs_bucket'),
+        extra_url_components=master_config.get('bisect_build_gs_extra'))
+
   def _build_gs_archive_url(self, mastername, master_config, buildername):
     """Returns the archive URL to pass to self.m.archive.zip_and_upload_build.