Archive Linux perf builds for manual bisect

scripts/slave/recipe_modules/chromium_tests/api.py

Index: scripts/slave/recipe_modules/chromium_tests/api.py
diff --git a/scripts/slave/recipe_modules/chromium_tests/api.py b/scripts/slave/recipe_modules/chromium_tests/api.py
index 4fa44f2ce533601fe503345ff7a2e49eae20635b..986efd81742285aa3305170c27a1ef0fe9c018dc 100644
--- a/scripts/slave/recipe_modules/chromium_tests/api.py
+++ b/scripts/slave/recipe_modules/chromium_tests/api.py
@@ -406,6 +406,25 @@ class ChromiumTestsApi(recipe_api.RecipeApi):
       if not bot_config.get('cf_archive_build'):
         master_config = bot_db.get_master_settings(mastername)
         build_revision = update_step.presentation.properties['got_revision']
+
+        # For archiving 'chromium.perf', the builder also archives a version without perf test files.

[dimu1, 2016/07/07 21:54:11]

nit: 80 words

+        if mastername.startswith('chromium.perf'):
+          self.m.archive.zip_and_upload_build(
+              'package build',
+              self.m.chromium.c.build_config_fs,
+              build_url=self._build_gs_archive_url(
+                  mastername, master_config, buildername, no_symbol_save = True),
+              build_revision=build_revision,
+              cros_board=self.m.chromium.c.TARGET_CROS_BOARD,
+              # TODO(machenbach): Make asan a configuration switch.
+              package_dsym_files=(
+                  self.m.chromium.c.gyp_env.GYP_DEFINES.get('asan') and
+                  self.m.chromium.c.HOST_PLATFORM == 'mac'),
+              update_properties = update_step.presentation.properties,

[dimu1, 2016/07/07 21:54:11]

nit: remove the space around '='

+              includePerfTestFiles = False,
+              store_by_hash = False
+          )
+
         self.m.archive.zip_and_upload_build(
             'package build',
             self.m.chromium.c.build_config_fs,
@@ -474,6 +493,7 @@ class ChromiumTestsApi(recipe_api.RecipeApi):
                                build_revision=None, override_bot_type=None):
     assert isinstance(bot_db, bdb_module.BotConfigAndTestDB), \
         "bot_db argument %r was not a BotConfigAndTestDB" % (bot_db)
+
     # We only want to do this for tester bots (i.e. those which do not compile
     # locally).
     bot_type = override_bot_type or bot_db.get_bot_config(
@@ -762,7 +782,7 @@ class ChromiumTestsApi(recipe_api.RecipeApi):
       self.m.swarming.add_default_tag('purpose:post-commit')
       self.m.swarming.add_default_tag('purpose:CI')
 
-  def _build_gs_archive_url(self, mastername, master_config, buildername):
+  def _build_gs_archive_url(self, mastername, master_config, buildername, no_symbol_save = False):

[dimu1, 2016/07/07 21:54:11]

rename to saveSymbol or stripSymbol

     """Returns the archive URL to pass to self.m.archive.zip_and_upload_build.
 
     Most builders on most masters use a standard format for the build archive
@@ -776,6 +796,10 @@ class ChromiumTestsApi(recipe_api.RecipeApi):
         (as set on the master's configuration) is used instead.
     """
     if mastername.startswith('chromium.perf'):
+      if no_symbol_save:
+        return self.m.archive.legacy_upload_url(
+          master_config.get('strip_build_gs_bucket'),

[dimu1, 2016/07/07 21:54:11]

rename the bucket key

+          extra_url_components=None)
       return self.m.archive.legacy_upload_url(
           master_config.get('build_gs_bucket'),
           extra_url_components=None)