 Chromium Code Reviews
 Chromium Code Reviews Issue 2128613005:
  Archive Linux perf builds for manual bisect  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
    
  
    Issue 2128613005:
  Archive Linux perf builds for manual bisect  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master| Index: scripts/common/chromium_utils.py | 
| diff --git a/scripts/common/chromium_utils.py b/scripts/common/chromium_utils.py | 
| index 07b0d5d709541707ad680cd128052b8498469be2..70992c743cdeab52512d03894575b7985514fa5d 100644 | 
| --- a/scripts/common/chromium_utils.py | 
| +++ b/scripts/common/chromium_utils.py | 
| @@ -600,7 +600,7 @@ def CopyFileToDir(src_path, dest_dir, dest_fn=None, link_ok=False): | 
| def MakeZip(output_dir, archive_name, file_list, file_relative_dir, | 
| - raise_error=True, remove_archive_directory=True): | 
| + raise_error=True, remove_archive_directory=True, strip_files = None): | 
| """Packs files into a new zip archive. | 
| Files are first copied into a directory within the output_dir named for | 
| @@ -624,6 +624,7 @@ def MakeZip(output_dir, archive_name, file_list, file_relative_dir, | 
| the list is not found. | 
| remove_archive_directory: Whether to remove the archive staging directory | 
| before copying files over to it. | 
| + strip_files: List of executable files to strip symbols when zipping | 
| Returns: | 
| A tuple consisting of (archive_dir, zip_file_path), where archive_dir | 
| @@ -671,8 +672,14 @@ def MakeZip(output_dir, archive_name, file_list, file_relative_dir, | 
| dest_dir = os.path.join(archive_dir, dirname) | 
| MaybeMakeDirectory(dest_dir) | 
| CopyFileToDir(src_path, dest_dir, basename, link_ok=True) | 
| + if strip_files and basename in strip_files: | 
| + cmd = ['strip', os.path.join(dest_dir, basename)] | 
| 
stgao
2016/07/12 20:40:40
Will the strip also run on Mac and Windows? If so,
 
miimnk
2016/07/13 01:12:48
No. Strip will not run on Mac and Windows because
 | 
| + RunCommand(cmd) | 
| else: | 
| CopyFileToDir(src_path, archive_dir, basename, link_ok=True) | 
| + if strip_files and basename in strip_files: | 
| + cmd = ['strip', os.path.join(archive_dir, basename)] | 
| + RunCommand(cmd) | 
| except PathNotFound: | 
| if raise_error: | 
| raise |