scripts/slave/recipe_modules/archive/perf_test_files.py - Issue 2128613005: Archive Linux perf builds for manual bisect

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: scripts/slave/recipe_modules/archive/perf_test_files.py

Issue 2128613005: Archive Linux perf builds for manual bisect (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Archive Linux perf builds for manual bisect Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« scripts/slave/recipe_modules/archive/api.py ('K') | « scripts/slave/recipe_modules/archive/api.py ('k') | scripts/slave/recipe_modules/chromium_tests/api.py » ('j') | scripts/slave/recipe_modules/chromium_tests/api.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 # Copyright 2016 The Chromium Authors. All rights reserved.
	dtu 2016/08/05 21:06:18 Name could be misleading -- these files aren't use Name could be misleading -- these files aren't used for perf tests. Maybe manual_bisect_files? miimnk 2016/08/08 22:41:24 Done. Show quoted text On 2016/08/05 21:06:18, dtu wrote: > Name could be misleading -- these files aren't used for perf tests. Maybe > manual_bisect_files? Done.
	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 """Declares required files to run bisect on chrome Linux builds in perf.

	6 Binary files that should be stripped to reduce zip file size are declared.

	7 """

	8

	9 CHROME_REQUIRED_FILES = [
	dtu 2016/08/05 21:06:19 nit: Alphabetize this list. Also, is there any wa nit: Alphabetize this list. Also, is there any way to get the ground truth as to which files are required? This seems like it may break at unexpected times, and then the perf sheriff will be responsible. I notice there's a chrome.isolate in chromium src -- maybe that could be useful? Also, can you comment with where the list came from / how someone can reproduce the list? miimnk 2016/08/08 22:41:25 i) Alphabetized the list. ii) Yes, it is possible Show quoted text On 2016/08/05 21:06:19, dtu wrote: > nit: Alphabetize this list. > > Also, is there any way to get the ground truth as to which files are required? > This seems like it may break at unexpected times, and then the perf sheriff will > be responsible. I notice there's a chrome.isolate in chromium src -- maybe that > could be useful? > > Also, can you comment with where the list came from / how someone can reproduce > the list? i) Alphabetized the list. ii) Yes, it is possible that the archive might not be able to execute Chrome unexpectedly in the future if archive files change. But the file list seems to be able to work for all the previous ~80000 builds. Also, I passed the file list to chromium_utils.MakeZip with raise_error parameter as False. Thus, even if some files get missing later, it will not break the buildbot. The file list was gotten from the local chrome executable path in Linux. (This can be retrieved by typing 'chrome://version' in chrome and following the executable path. I added this into the comments.
	10 'locales',

	11 'default_apps',

	12 'PepperFlash',

	13 'chrome',

	14 'resources.pak',

	15 'icudtl.dat',

	16 'libwidevinecdm.so',

	17 'nacl_irt_x86_64.nexe',

	18 'nacl_helper',

	19 'chrome_200_percent.pak',

	20 'snapshot_blob.bin',

	21 'chrome_100_percent.pak',

	22 'natives_blob.bin',

	23 'xdg-mime',

	24 'nacl_helper_bootstrap',

	25 'xdg-settings',

	26 'product_logo_48.png'

	27 ]

	28

	29

	30 CHROME_STRIP_LIST = [

	31 'chrome',

	32 'nacl_helper'

	33 ]

OLD	NEW