Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: test/cctest/libsampler/test-sampler.cc

Issue 2128613004: Move SimulatorHelper into V8 out of profiler clients. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: addressing comments. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/profiler/tick-sample.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/libsampler/test-sampler.cc
diff --git a/test/cctest/libsampler/test-sampler.cc b/test/cctest/libsampler/test-sampler.cc
index c2b11ce77c0ad72919722bc14488a8d3d9ecbbc0..b88d3479144d9e1ce5a8137b2cc1ccd4b2dd2134 100644
--- a/test/cctest/libsampler/test-sampler.cc
+++ b/test/cctest/libsampler/test-sampler.cc
@@ -41,10 +41,9 @@ class TestSampler : public Sampler {
explicit TestSampler(Isolate* isolate) : Sampler(isolate) {}
void SampleStack(const v8::RegisterState& regs) override {
- void* frames[Sampler::kMaxFramesCount];
+ void* frames[kMaxFramesCount];
SampleInfo sample_info;
- isolate()->GetStackSample(regs, reinterpret_cast<void**>(frames),
- Sampler::kMaxFramesCount, &sample_info);
+ isolate()->GetStackSample(regs, frames, kMaxFramesCount, &sample_info);
if (is_counting_samples_) {
if (sample_info.vm_state == JS) ++js_sample_count_;
if (sample_info.vm_state == EXTERNAL) ++external_sample_count_;
« no previous file with comments | « src/profiler/tick-sample.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698