Move SimulatorHelper into V8 out of profiler clients.

src/api.cc

Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index 07351c9aab150fb42e9c20d33192cd0700e448ee..2dcf437f762f3b8107b63d14198c2f04301b6bd8 100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -7580,20 +7580,12 @@ bool Isolate::GetHeapCodeAndMetadataStatistics(
 
 void Isolate::GetStackSample(const RegisterState& state, void** frames,
                              size_t frames_limit, SampleInfo* sample_info) {
-#if defined(USE_SIMULATOR)
-  RegisterState regs;
-  i::Isolate* isolate = reinterpret_cast<i::Isolate*>(this);
-  if (!i::SimulatorHelper::FillRegisters(isolate, &regs)) {
-    sample_info->frames_count = 0;
-    sample_info->vm_state = OTHER;
-    sample_info->external_callback_entry = nullptr;
+  if (TickSample::GetStackSample(this, state, TickSample::kSkipCEntryFrame,
+                                 frames, frames_limit, sample_info))
     return;

[Yang, 2016/07/08 08:40:46]

brackets around this please :)

[alph, 2016/07/08 21:47:42]

Done.

-  }
-#else
-  const RegisterState& regs = state;
-#endif
-  TickSample::GetStackSample(this, regs, TickSample::kSkipCEntryFrame, frames,
-                             frames_limit, sample_info);
+  sample_info->frames_count = 0;
+  sample_info->vm_state = OTHER;
+  sample_info->external_callback_entry = nullptr;
 }
 
 size_t Isolate::NumberOfPhantomHandleResetsSinceLastCall() {