Move SimulatorHelper into V8 out of profiler clients.

src/log.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/log.h"
 
 #include <cstdarg>
 #include <sstream>
 
 #include "src/bailout-reason.h"
@@ skipping 601 matching lines @@
   bool paused_;
 };
 
 
 //
 // Ticker used to provide ticks to the profiler and the sliding state
 // window.
 //
 class Ticker: public sampler::Sampler {
  public:
-  Ticker(Isolate* isolate, int interval):
-      sampler::Sampler(reinterpret_cast<v8::Isolate*>(isolate)),
-      profiler_(NULL),
-      sampling_thread_(new SamplingThread(this, interval)) {}
+  Ticker(Isolate* isolate, int interval)
+      : sampler::Sampler(reinterpret_cast<v8::Isolate*>(isolate)),
+        profiler_(nullptr),
+        sampling_thread_(new SamplingThread(this, interval)) {}
 
   ~Ticker() {
     if (IsActive()) Stop();
     delete sampling_thread_;
   }
 
   void SetProfiler(Profiler* profiler) {
-    DCHECK(profiler_ == NULL);
+    DCHECK(profiler_ == nullptr);
     profiler_ = profiler;
     IncreaseProfilingDepth();
     if (!IsActive()) Start();
     sampling_thread_->StartSynchronously();
   }
 
   void ClearProfiler() {
-    profiler_ = NULL;
+    profiler_ = nullptr;
     if (IsActive()) Stop();
     DecreaseProfilingDepth();
     sampling_thread_->Join();
   }
 
   void SampleStack(const v8::RegisterState& state) override {
     if (!profiler_) return;
-    v8::Isolate* v8_isolate = isolate();
-    Isolate* i_isolate = reinterpret_cast<Isolate*>(v8_isolate);
-#if defined(USE_SIMULATOR)
-    if (!SimulatorHelper::FillRegisters(i_isolate,
-                                        const_cast<v8::RegisterState*>(&state)))
-      return;
-#endif
+    Isolate* isolate = reinterpret_cast<Isolate*>(this->isolate());

[lpy, 2016/07/07 17:57:56]

Since sampler has a method called isolate(), should we avoid using `isolate` as
a temporary variable?

[alph, 2016/07/07 18:05:29]

What's wrong with it? I'm not aware of a policy/rule that prohibits using the
same name for a local variable.

[Yang, 2016/07/08 08:40:47]

I think this is fine. We do this elsewhere too.

     TickSample sample;
-    sample.Init(i_isolate, state, TickSample::kIncludeCEntryFrame, true);
+    sample.Init(isolate, state, TickSample::kIncludeCEntryFrame, true);
     profiler_->Insert(&sample);
   }
 
  private:
   Profiler* profiler_;
   SamplingThread* sampling_thread_;
 };
 
 
 //
@@ skipping 1203 matching lines @@
 
   if (profiler_listener_.get() != nullptr) {
     removeCodeEventListener(profiler_listener_.get());
   }
 
   return log_->Close();
 }
 
 }  // namespace internal
 }  // namespace v8