Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2128613003: Devirtualize AssignFeedbackVectorSlots (Closed)

Created:
4 years, 5 months ago by Toon Verwaest
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Devirtualize AssignFeedbackVectorSlots In AstNumberingVisitor we always know what node we're dealing with, so there's no reason for this method to be virtual. This additionally deletes 3 calls to AssignFeedbackVectorSlots that would always end up in the empty version. BUG= Committed: https://crrev.com/a5020673cccad404bcd58e4325145a7a79e4b05a Cr-Commit-Position: refs/heads/master@{#37582}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -21 lines) Patch
M src/ast/ast.h View 11 chunks +10 lines, -18 lines 0 comments Download
M src/ast/ast-numbering.cc View 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Toon Verwaest
mvstanton: ptal mstarzinger: owner review
4 years, 5 months ago (2016-07-07 06:31:19 UTC) #2
mvstanton
lgtm
4 years, 5 months ago (2016-07-07 07:55:29 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2128613003/1
4 years, 5 months ago (2016-07-07 07:58:39 UTC) #5
Michael Starzinger
LGTM.
4 years, 5 months ago (2016-07-07 08:00:34 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-07 08:24:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2128613003/1
4 years, 5 months ago (2016-07-07 11:24:00 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-07 11:26:01 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 11:26:04 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 11:27:01 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a5020673cccad404bcd58e4325145a7a79e4b05a
Cr-Commit-Position: refs/heads/master@{#37582}

Powered by Google App Engine
This is Rietveld 408576698