Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2545)

Unified Diff: pkg/custom_element/test/custom_element_test.dart

Issue 21286004: attempt to deflake IE9 mutation observer test (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/custom_element/test/custom_element_test.dart
diff --git a/pkg/custom_element/test/custom_element_test.dart b/pkg/custom_element/test/custom_element_test.dart
index d5894c2d49bcd95ac7c08f04e50b90a2d0414903..e2f920a18f2ad1321481e918abe5272fd0d8cc21 100644
--- a/pkg/custom_element/test/custom_element_test.dart
+++ b/pkg/custom_element/test/custom_element_test.dart
@@ -37,9 +37,12 @@ customElementTests() {
return new Future(() {
expect(xtag.lifecycle, ['created', 'inserted']);
element.remove();
- return new Future(() {
+ // TODO(jmesserly): the extra future here is to give IE9 time to deliver
+ // its event. This seems wrong. We'll probably need some cooperation
+ // between Dart and the polyfill to coordinate the microtask event loop.
+ return new Future(() => new Future(() {
expect(xtag.lifecycle, ['created', 'inserted', 'removed']);
- });
+ }));
});
});
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698