Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 2128583007: Revert of Use sRGB pixel config for ARGB masks (color emoji) (Closed)

Created:
4 years, 5 months ago by Brian Osman
Modified:
4 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Use sRGB pixel config for ARGB masks (color emoji) (patchset #1 id:1 of https://codereview.chromium.org/2129913004/ ) Reason for revert: Color text rendering failing on ANGLE Original issue's description: > Use sRGB pixel config for ARGB masks (color emoji) > > Fixes over-bright color emoji and GM:colortype in sRGB mode > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2129913004 > > Committed: https://skia.googlesource.com/skia/+/920af9fac3d9e275a93910d9c626ee7bc23ed17a TBR=bungeman@google.com,jvanverth@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/180500e5f1d376298de753dc9edefc7e9b25e655

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/gpu/text/GrBatchFontCache.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/text/GrBatchFontCache.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Osman
Created Revert of Use sRGB pixel config for ARGB masks (color emoji)
4 years, 5 months ago (2016-07-07 20:18:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2128583007/1
4 years, 5 months ago (2016-07-07 20:18:46 UTC) #3
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 20:18:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/180500e5f1d376298de753dc9edefc7e9b25e655

Powered by Google App Engine
This is Rietveld 408576698