chrome/common/safe_browsing/csd.proto - Issue 2128583005: DownloadProtection: Add more graceful handling of verdict=UNKNOWN

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/safe_browsing/csd.proto

Issue 2128583005: DownloadProtection: Add more graceful handling of verdict=UNKNOWN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/safe_browsing/download_protection_service.cc ('K') | « chrome/browser/safe_browsing/download_protection_service_unittest.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/safe_browsing/csd.proto

diff --git a/chrome/common/safe_browsing/csd.proto b/chrome/common/safe_browsing/csd.proto

index 01214f167c67eab8e610fbb7f088f661bfb199bd..f2dadfd9d4850d518b2d4b185c35ab58f7de4c01 100644

--- a/chrome/common/safe_browsing/csd.proto

+++ b/chrome/common/safe_browsing/csd.proto

@@ -390,12 +390,15 @@ message ClientDownloadResponse {

// Download is considered dangerous. Chrome should show a warning to the

// user.

DANGEROUS = 1;

- // Download is unknown. Chrome should display a less severe warning.

+ // Download is uncommon. Chrome should display a less severe warning.

UNCOMMON = 2;

// The download is potentially unwanted.

POTENTIALLY_UNWANTED = 3;

// The download is from a dangerous host.

DANGEROUS_HOST = 4;

+ // The backend doesn't have confidence in its verdict of this file.

+ // Chrome should show the default warning if configured for this file type.

+ UNKNOWN = 5;

}

required Verdict verdict = 1;