Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1201)

Issue 2128583004: Add a standard placement new operator to WTF_USE_ALLOCATOR. (Closed)

Created:
4 years, 5 months ago by yzshen1
Modified:
4 years, 5 months ago
Reviewers:
haraken, esprehn
CC:
blink-reviews, blink-reviews-wtf_chromium.org, chromium-reviews, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a standard placement new operator to WTF_USE_ALLOCATOR. So that types using WTF_USE_ALLOCATOR can work with WTF::Optional. BUG=624140 Committed: https://crrev.com/51fad7a9410e6ac54bd38b4cd02bce9ee81230ee Cr-Commit-Position: refs/heads/master@{#404167}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M third_party/WebKit/Source/wtf/VectorTest.cpp View 2 chunks +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/allocator/PartitionAllocator.h View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (4 generated)
yzshen1
Hi, Elliott. Would you please take a look? Thanks!
4 years, 5 months ago (2016-07-06 18:55:03 UTC) #2
esprehn
This looks good to me but haraken should look too.
4 years, 5 months ago (2016-07-06 20:12:17 UTC) #4
haraken
LGTM
4 years, 5 months ago (2016-07-07 00:07:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2128583004/1
4 years, 5 months ago (2016-07-07 15:39:45 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-07 17:39:08 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 17:39:25 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 17:41:17 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/51fad7a9410e6ac54bd38b4cd02bce9ee81230ee
Cr-Commit-Position: refs/heads/master@{#404167}

Powered by Google App Engine
This is Rietveld 408576698