third_party/WebKit/Source/web/WebPagePopupImpl.cpp - Issue 2128563002: Move scheduleAnimation calls from WebViewClient to WebWidgetClient.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebPagePopupImpl.cpp

Issue 2128563002: Move scheduleAnimation calls from WebViewClient to WebWidgetClient. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/web/WebPagePopupImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebPagePopupImpl.cpp b/third_party/WebKit/Source/web/WebPagePopupImpl.cpp

index 94757f03c0fe13d1b72c36630e6fc51e47b1327c..36b72dcf11fb8de23920abcbc7d64f8c1fbcd37c 100644

--- a/third_party/WebKit/Source/web/WebPagePopupImpl.cpp

+++ b/third_party/WebKit/Source/web/WebPagePopupImpl.cpp

@@ -123,7 +123,7 @@ private:

{

// Calling scheduleAnimation on m_webView so WebTestProxy will call beginFrame.

if (LayoutTestSupport::isRunningLayoutTest())

- m_popup->m_webView->scheduleAnimation();

+ m_popup->m_webView->mainFrameImpl()->frameWidget()->scheduleAnimation();

if (m_popup->isAcceleratedCompositingActive()) {

DCHECK(m_popup->m_layerTreeView);

« no previous file with comments | « third_party/WebKit/Source/web/LinkHighlightImpl.cpp ('k') | third_party/WebKit/Source/web/WebViewFrameWidget.cpp » ('j') | no next file with comments »