Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Unified Diff: third_party/WebKit/Source/core/page/scrolling/RootViewportScrollCallback.h

Issue 2128553002: Make rootScroller the layout viewport. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@viewportScrollCallbackInterface
Patch Set: Rebase + comment fix in test Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/page/scrolling/RootViewportScrollCallback.h
diff --git a/third_party/WebKit/Source/core/page/scrolling/RootViewportScrollCallback.h b/third_party/WebKit/Source/core/page/scrolling/RootViewportScrollCallback.h
index ea52090dc3149b4621b18dddf3eed8fb4c2cf55c..a1a7ebbe8a663df0155107211e44a79f8dc8de75 100644
--- a/third_party/WebKit/Source/core/page/scrolling/RootViewportScrollCallback.h
+++ b/third_party/WebKit/Source/core/page/scrolling/RootViewportScrollCallback.h
@@ -16,6 +16,7 @@ class ScrollableArea;
class ScrollState;
class TopControls;
class OverscrollController;
+class RootFrameViewport;
// The ViewportScrollCallback used by the one root frame on the page. This
// callback provides scrolling of the frame as well as associated actions like
@@ -25,9 +26,12 @@ public:
// The TopControls and OverscrollController are given to the
// RootViewportScrollCallback but are not owned or kept alive by it.
static RootViewportScrollCallback* create(
- TopControls* topControls, OverscrollController* overscrollController)
+ TopControls* topControls,
+ OverscrollController* overscrollController,
+ RootFrameViewport& rootFrameViewport)
{
- return new RootViewportScrollCallback(topControls, overscrollController);
+ return new RootViewportScrollCallback(
+ topControls, overscrollController, rootFrameViewport);
}
virtual ~RootViewportScrollCallback();
@@ -40,14 +44,14 @@ public:
private:
// RootViewportScrollCallback does not assume ownership of TopControls or of
// OverscrollController.
- RootViewportScrollCallback(TopControls*, OverscrollController*);
+ RootViewportScrollCallback(TopControls*, OverscrollController*, RootFrameViewport&);
bool shouldScrollTopControls(const FloatSize&, ScrollGranularity) const;
bool scrollTopControls(ScrollState&);
WeakMember<TopControls> m_topControls;
WeakMember<OverscrollController> m_overscrollController;
- WeakMember<ScrollableArea> m_scroller;
+ WeakMember<RootFrameViewport> m_rootFrameViewport;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698