Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2128493002: Revert of [gn] Switch more linux32 bots to gn (Closed)

Created:
4 years, 5 months ago by Michael Achenbach
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [gn] Switch more linux32 bots to gn (patchset #3 id:40001 of https://codereview.chromium.org/2122933002/ ) Reason for revert: Breaks test isolation on shared library bot. Original issue's description: > [gn] Switch more linux32 bots to gn > > This switches nosnap and shared library bots to gn. > > This also unsets external startup data if no snapshot is > used. > > BUG=chromium:474921 > NOTRY=true > > Committed: https://crrev.com/ab4d8fc07d9d35e6fc129098f42aa0317a02244a > Cr-Commit-Position: refs/heads/master@{#37546} TBR=vogelheim@chromium.org,jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:474921 Committed: https://crrev.com/a5fa2984257a50ee9440914c7d1a199f64a86194 Cr-Commit-Position: refs/heads/master@{#37548}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -22 lines) Patch
M gni/v8.gni View 1 chunk +1 line, -7 lines 0 comments Download
M infra/mb/mb_config.pyl View 6 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Achenbach
Created Revert of [gn] Switch more linux32 bots to gn
4 years, 5 months ago (2016-07-06 10:13:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2128493002/1
4 years, 5 months ago (2016-07-06 10:13:30 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-06 10:13:45 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a5fa2984257a50ee9440914c7d1a199f64a86194 Cr-Commit-Position: refs/heads/master@{#37548}
4 years, 5 months ago (2016-07-06 10:16:34 UTC) #6
Michael Achenbach
4 years, 5 months ago (2016-07-06 15:09:04 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2126843002/ by machenbach@chromium.org.

The reason for reverting is: Should be fixed after
https://codereview.chromium.org/2123223002/.

Powered by Google App Engine
This is Rietveld 408576698