Issue 212843007: Update .gn files to use new template syntax.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 212843007: Update .gn files to use new template syntax. (Closed)

Created:
6 years, 9 months ago by brettw

Modified:
6 years, 9 months ago

Reviewers:
scottmg

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Update .gn files to use new template syntax. This uses the invoker() syntax. R=scottmg@chromium.org, scottmg Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260151

Total comments: 1

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -13 lines)			Patch
M	build/config/linux/pkg_config.gni	View		2 chunks	+7 lines, -3 lines	0 comments	Download
M	build/toolchain/gcc_toolchain.gni	View		2 chunks	+19 lines, -2 lines	0 comments	Download
M	tools/gn/bin/linux/gn.sha1	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/gn/bin/linux/gn32.sha1	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/gn/bin/mac/gn.sha1	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/gn/bin/win/gn.exe.sha1	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/gn/secondary/tools/grit/grit_rule.gni	View		2 chunks	+6 lines, -4 lines	0 comments	Download

Total messages: 4 (0 generated)

brettw

This will require an upcoming patch to work but I thought you would want to ...

6 years, 9 months ago (2014-03-26 21:48:29 UTC) #1

brettw

The required patch is https://codereview.chromium.org/212933008/

6 years, 9 months ago (2014-03-26 21:54:42 UTC) #2

scottmg

lgtm, the defined() everywhere seems a bit unfortunate, but I'm not sure what to do ...

6 years, 9 months ago (2014-03-27 18:00:59 UTC) #3

brettw

6 years, 9 months ago (2014-03-28 16:19:05 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r260151 (presubmit successful).