Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 212843003: DevTools: Add TimelinePowerGraph (Closed)

Created:
6 years, 9 months ago by Pan
Modified:
6 years, 8 months ago
Reviewers:
apavlov, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

This change adds TimelinePowerGraph in Timeline panel, it allows zoom in of power overview, and provides instant power values via mouse move. BUG=337138 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170397

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -6 lines) Patch
M Source/devtools/devtools.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/CountersGraph.js View 2 chunks +1 line, -5 lines 0 comments Download
M Source/devtools/front_end/MemoryCountersGraph.js View 1 chunk +8 lines, -0 lines 0 comments Download
M Source/devtools/front_end/TimelinePanel.js View 2 chunks +2 lines, -1 line 0 comments Download
A Source/devtools/front_end/TimelinePowerGraph.js View 1 1 chunk +44 lines, -0 lines 0 comments Download
M Source/devtools/scripts/frontend_modules.json View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Pan
Hi @pfeldman, This change reuses CountersGraph to construct a TimelinePowerGraph. The differece is memory counters ...
6 years, 9 months ago (2014-03-26 14:13:59 UTC) #1
pfeldman
lgtm https://codereview.chromium.org/212843003/diff/1/Source/devtools/front_end/TimelinePowerGraph.js File Source/devtools/front_end/TimelinePowerGraph.js (right): https://codereview.chromium.org/212843003/diff/1/Source/devtools/front_end/TimelinePowerGraph.js#newcode17 Source/devtools/front_end/TimelinePowerGraph.js:17: if (Capabilities.canProfilePower) I don't think you need this ...
6 years, 9 months ago (2014-03-26 14:22:54 UTC) #2
Pan
https://codereview.chromium.org/212843003/diff/1/Source/devtools/front_end/TimelinePowerGraph.js File Source/devtools/front_end/TimelinePowerGraph.js (right): https://codereview.chromium.org/212843003/diff/1/Source/devtools/front_end/TimelinePowerGraph.js#newcode17 Source/devtools/front_end/TimelinePowerGraph.js:17: if (Capabilities.canProfilePower) On 2014/03/26 14:22:54, pfeldman wrote: > I ...
6 years, 9 months ago (2014-03-26 14:30:53 UTC) #3
Pan
The CQ bit was checked by pan.deng@intel.com
6 years, 9 months ago (2014-03-26 14:40:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pan.deng@intel.com/212843003/60001
6 years, 9 months ago (2014-03-26 14:40:24 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 15:11:42 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 9 months ago (2014-03-26 15:11:42 UTC) #7
Pan
The CQ bit was checked by pan.deng@intel.com
6 years, 9 months ago (2014-03-28 15:11:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pan.deng@intel.com/212843003/60001
6 years, 9 months ago (2014-03-28 15:11:29 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 15:50:24 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-28 15:50:25 UTC) #11
Pan
The CQ bit was checked by pan.deng@intel.com
6 years, 8 months ago (2014-03-29 01:48:27 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pan.deng@intel.com/212843003/60001
6 years, 8 months ago (2014-03-29 01:48:38 UTC) #13
commit-bot: I haz the power
6 years, 8 months ago (2014-03-29 01:49:01 UTC) #14
Message was sent while issue was closed. 
Change committed as 170397

Powered by Google App Engine
This is Rietveld 408576698