Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: src/IceInstrumentation.cpp

Issue 2128383002: Blacklisted instrumenting _Balloc. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Simplified black list check Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceInstrumentation.h ('k') | tests_lit/asan_tests/blacklist.ll » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceInstrumentation.cpp
diff --git a/src/IceInstrumentation.cpp b/src/IceInstrumentation.cpp
index c911a0b449e08d52a56dfbcea06ea7c18d3e4b52..0cd218abcbdbd7df2507cab8808dbcfdb7db5c20 100644
--- a/src/IceInstrumentation.cpp
+++ b/src/IceInstrumentation.cpp
@@ -29,17 +29,18 @@ void Instrumentation::instrumentFunc(Cfg *Func) {
assert(Func);
assert(!Func->getNodes().empty());
- // TODO(tlively): More selectively instrument functions so that shadow memory
- // represents user accessibility more and library accessibility less.
- bool DidInstrumentStart = false;
+ if (!isInstrumentable(Func))
+ return;
+
+ bool DidInstrumentEntry = false;
LoweringContext Context;
Context.init(Func->getNodes().front());
for (CfgNode *Node : Func->getNodes()) {
Context.init(Node);
while (!Context.atEnd()) {
- if (!DidInstrumentStart) {
+ if (!DidInstrumentEntry) {
instrumentFuncStart(Context);
- DidInstrumentStart = true;
+ DidInstrumentEntry = true;
}
instrumentInst(Context);
// go to next undeleted instruction
« no previous file with comments | « src/IceInstrumentation.h ('k') | tests_lit/asan_tests/blacklist.ll » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698