Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Issue 2128383002: Blacklisted instrumenting _Balloc. (Closed)

Created:
4 years, 5 months ago by tlively
Modified:
4 years, 5 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Blacklisted instrumenting _Balloc. Increases number of spec2k tests that run successfully with ASan from 2 to 6. BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4374 R=kschimpf@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=3f97afb1675218f1a4cd7f30fc4faa86fcbeea03

Patch Set 1 #

Total comments: 2

Patch Set 2 : Simplified black list check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -22 lines) Patch
M Makefile.standalone View 1 chunk +1 line, -1 line 0 comments Download
M runtime/szrt_asan.c View 7 chunks +23 lines, -13 lines 0 comments Download
M src/IceASanInstrumentation.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/IceASanInstrumentation.cpp View 1 4 chunks +10 lines, -3 lines 0 comments Download
M src/IceInstrumentation.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/IceInstrumentation.cpp View 1 chunk +6 lines, -5 lines 0 comments Download
A tests_lit/asan_tests/blacklist.ll View 1 chunk +49 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tlively
4 years, 5 months ago (2016-07-07 21:12:16 UTC) #2
Karl
lgtm https://codereview.chromium.org/2128383002/diff/1/src/IceASanInstrumentation.cpp File src/IceASanInstrumentation.cpp (right): https://codereview.chromium.org/2128383002/diff/1/src/IceASanInstrumentation.cpp#newcode66 src/IceASanInstrumentation.cpp:66: return FuncName == "" || FuncBlackList.find(FuncName) == FuncBlackList.end(); ...
4 years, 5 months ago (2016-07-07 21:20:49 UTC) #3
tlively
Committed patchset #2 (id:20001) manually as 3f97afb1675218f1a4cd7f30fc4faa86fcbeea03 (presubmit successful).
4 years, 5 months ago (2016-07-07 21:56:26 UTC) #5
tlively
4 years, 5 months ago (2016-07-08 16:56:21 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/2128383002/diff/1/src/IceASanInstrumentation.cpp
File src/IceASanInstrumentation.cpp (right):

https://codereview.chromium.org/2128383002/diff/1/src/IceASanInstrumentation....
src/IceASanInstrumentation.cpp:66: return FuncName == "" ||
FuncBlackList.find(FuncName) == FuncBlackList.end();
On 2016/07/07 21:20:49, Karl wrote:
> Actually, a simpler test is:
> 
>     || FuncBlackList.count(FuncName) == 0;

Done.

Powered by Google App Engine
This is Rietveld 408576698