Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2128363002: Moved viewport layer registration into WebViewImpl. (Closed)

Created:
4 years, 5 months ago by bokan
Modified:
4 years, 5 months ago
CC:
blink-reviews, chromium-reviews, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@rootScrollerPinchedIn2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moved viewport layer registration into WebViewImpl. This is currently done inside VisualViewport by passing it a pointer to the WebLayerViewView and letting it register all the viewport related layers. This isn't the right place to do it since not all the layers are related to the VisualViewport. Additionally, it requires VisualViewport to be more aware of compositing than it should be. BUG=505516 Committed: https://crrev.com/a2c06cf000f191caa07b13be0537844cf6448402 Cr-Commit-Position: refs/heads/master@{#404359}

Patch Set 1 #

Patch Set 2 : Moved visual viewport layer registration into WebViewImpl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -42 lines) Patch
M third_party/WebKit/Source/core/frame/VisualViewport.h View 1 3 chunks +10 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/VisualViewport.cpp View 1 3 chunks +4 lines, -36 lines 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 3 chunks +32 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 14 (7 generated)
bokan
4 years, 5 months ago (2016-07-07 21:23:06 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2128363002/20001
4 years, 5 months ago (2016-07-07 21:24:15 UTC) #5
aelias_OOO_until_Jul13
lgtm
4 years, 5 months ago (2016-07-07 21:53:28 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_gyp_rel on master.tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
4 years, 5 months ago (2016-07-07 23:26:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2128363002/20001
4 years, 5 months ago (2016-07-08 14:07:09 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-08 14:13:29 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 14:15:53 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a2c06cf000f191caa07b13be0537844cf6448402
Cr-Commit-Position: refs/heads/master@{#404359}

Powered by Google App Engine
This is Rietveld 408576698