Issue 212833002: [msan] Do not unpoison heap if running on simulator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 212833002: [msan] Do not unpoison heap if running on simulator. (Closed)

Created:
6 years, 9 months ago by eugenis

Modified:
6 years, 8 months ago

Reviewers:
danno, Jakob Kummerow

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

[msan] Do not unpoison heap if running on simulator. With the simulator, MSan detects all memory accesses from JIT code without the need for annotations. We'd like to keep the annotation in the native (w/o simulator) mode until we can move all MSan+V8 users to simulator mode. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20399

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -5 lines)			Patch
	M	src/msan.h	View		2 chunks	+6 lines, -4 lines	0 comments	Download
	M	src/spaces.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

6 years, 8 months ago (2014-04-01 12:45:19 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r20399 (presubmit successful).

Expand Messages | Collapse Messages