Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2128273003:
Use AudioDeviceFactory instead of GetAudioHardwareConfig to fetch audio output device parameters in… (Closed)
|
Created:
4 years, 5 months ago by Guido Urdaneta Modified:
4 years, 5 months ago CC:
chromium-reviews, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUse AudioDeviceFactory instead of GetAudioHardwareConfig to fetch audio output device parameters in Blink platform.
This is in anticipation to the removal of RenderThreadImpl::GetAudioHardwareConfig()
BUG=611404, 549125
Committed: https://crrev.com/1289f96885ccaa8949668391c8d6d33667b83973
Cr-Commit-Position: refs/heads/master@{#404889}
Patch Set 1 #
Messages
Total messages: 18 (9 generated)
guidou@chromium.org changed reviewers: + esprehn@chromium.org
Hi, PTAL
Description was changed from ========== Use AudioDeviceFactory instead of GetAudioHardwareConfig to fetch audio output device parameters in Blink platform. BUG=611404 ========== to ========== Use AudioDeviceFactory instead of GetAudioHardwareConfig to fetch audio output device parameters in Blink platform. This is in anticipation to the removal of RenderThreadImpl::GetAudioHardwareConfig() BUG=611404 ==========
guidou@chromium.org changed reviewers: + jochen@chromium.org - esprehn@chromium.org
jochen@, please take a look
lgtm
The CQ bit was checked by guidou@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by olka@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Use AudioDeviceFactory instead of GetAudioHardwareConfig to fetch audio output device parameters in Blink platform. This is in anticipation to the removal of RenderThreadImpl::GetAudioHardwareConfig() BUG=611404 ========== to ========== Use AudioDeviceFactory instead of GetAudioHardwareConfig to fetch audio output device parameters in Blink platform. This is in anticipation to the removal of RenderThreadImpl::GetAudioHardwareConfig() BUG=611404 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Use AudioDeviceFactory instead of GetAudioHardwareConfig to fetch audio output device parameters in Blink platform. This is in anticipation to the removal of RenderThreadImpl::GetAudioHardwareConfig() BUG=611404 ========== to ========== Use AudioDeviceFactory instead of GetAudioHardwareConfig to fetch audio output device parameters in Blink platform. This is in anticipation to the removal of RenderThreadImpl::GetAudioHardwareConfig() BUG=611404 Committed: https://crrev.com/1289f96885ccaa8949668391c8d6d33667b83973 Cr-Commit-Position: refs/heads/master@{#404889} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/1289f96885ccaa8949668391c8d6d33667b83973 Cr-Commit-Position: refs/heads/master@{#404889}
Message was sent while issue was closed.
Description was changed from ========== Use AudioDeviceFactory instead of GetAudioHardwareConfig to fetch audio output device parameters in Blink platform. This is in anticipation to the removal of RenderThreadImpl::GetAudioHardwareConfig() BUG=611404 Committed: https://crrev.com/1289f96885ccaa8949668391c8d6d33667b83973 Cr-Commit-Position: refs/heads/master@{#404889} ========== to ========== Use AudioDeviceFactory instead of GetAudioHardwareConfig to fetch audio output device parameters in Blink platform. This is in anticipation to the removal of RenderThreadImpl::GetAudioHardwareConfig() BUG=611404, 549125 Committed: https://crrev.com/1289f96885ccaa8949668391c8d6d33667b83973 Cr-Commit-Position: refs/heads/master@{#404889} ========== |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
