chrome/browser/ui/views/frame/browser_view.cc - Issue 2128243003: Make most browser accelerators not repeat.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 2128243003: Make most browser accelerators not repeat. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update comment in test Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/frame/browser_view.cc

diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc

index 9bdc2b2b80422a72497dde99de4a309aabb7b047..75a53972a79f4d7878ef5ac32785ed139bc77186 100644

--- a/chrome/browser/ui/views/frame/browser_view.cc

+++ b/chrome/browser/ui/views/frame/browser_view.cc

@@ -2017,6 +2017,9 @@ bool BrowserView::AcceleratorPressed(const ui::Accelerator& accelerator) {

DCHECK(iter != accelerator_table_.end());

int command_id = iter->second;

+ if (accelerator.IsRepeat() && !chrome::IsCommandRepeatable(command_id))

+ return false;

chrome::BrowserCommandController* controller = browser_->command_controller();

if (!controller->block_command_execution())

UpdateAcceleratorMetrics(accelerator, command_id);