Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(930)

Unified Diff: chrome/browser/ui/views/frame/browser_view.h

Issue 2128243003: Make most browser accelerators not repeat. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use set and fix tests Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/accelerator_table.cc ('k') | chrome/browser/ui/views/frame/browser_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/frame/browser_view.h
diff --git a/chrome/browser/ui/views/frame/browser_view.h b/chrome/browser/ui/views/frame/browser_view.h
index 137ed8cf335f1b18de6262472bc984ce4a49660a..597fb94cba3a162c046e46a62d2b651c5e4c342f 100644
--- a/chrome/browser/ui/views/frame/browser_view.h
+++ b/chrome/browser/ui/views/frame/browser_view.h
@@ -657,9 +657,14 @@ class BrowserView : public BrowserWindow,
// The Status information bubble that appears at the bottom of the window.
std::unique_ptr<StatusBubbleViews> status_bubble_;
- // A mapping between accelerators and commands.
+ // A mapping between accelerators and command IDs.
std::map<ui::Accelerator, int> accelerator_table_;
+ // IDs of commands that should be executed in response to repeated
+ // accelerators (i.e. generated by holding keys down). Repeated accelerators
+ // are ignored otherwise.
+ std::set<int> repeatable_command_ids_;
sky 2016/09/01 19:31:06 How often do we trigger accelerators, especially o
Daniel Erat 2016/09/01 19:47:31 the local copy was initially due to mirroring the
+
// True if we have already been initialized.
bool initialized_;
« no previous file with comments | « chrome/browser/ui/views/accelerator_table.cc ('k') | chrome/browser/ui/views/frame/browser_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698