Make most browser accelerators not repeat.

chrome/browser/ui/views/frame/browser_view_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/browser_view.h"
 
 #include "base/macros.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/ui/browser_commands.h"
 #include "chrome/browser/ui/layout_constants.h"
 #include "chrome/browser/ui/views/bookmarks/bookmark_bar_view.h"
 #include "chrome/browser/ui/views/frame/browser_view_layout.h"
 #include "chrome/browser/ui/views/frame/test_with_browser_view.h"
 #include "chrome/browser/ui/views/frame/top_container_view.h"
 #include "chrome/browser/ui/views/infobars/infobar_container_view.h"
 #include "chrome/browser/ui/views/tabs/tab_strip.h"
 #include "chrome/browser/ui/views/toolbar/toolbar_view.h"
 #include "chrome/common/url_constants.h"
+#include "ui/base/accelerators/accelerator.h"
 #include "ui/views/controls/webview/webview.h"
 
 namespace {
 
 // Tab strip bounds depend on the window frame sizes.
 gfx::Point ExpectedTabStripOrigin(BrowserView* browser_view) {
   gfx::Rect tabstrip_bounds(
       browser_view->frame()->GetBoundsForTabStrip(browser_view->tabstrip()));
   gfx::Point tabstrip_origin(tabstrip_bounds.origin());
   views::View::ConvertPointToTarget(browser_view->parent(),
@@ skipping 126 matching lines @@
   EXPECT_FALSE(bookmark_bar->visible());
   EXPECT_FALSE(bookmark_bar->IsDetached());
   EXPECT_EQ(top_container, bookmark_bar->parent());
   // Top container is still third from front.
   EXPECT_EQ(browser_view()->child_count() - 3,
             browser_view()->GetIndexOf(top_container));
 
   BookmarkBarView::DisableAnimationsForTesting(false);
 }
 
+// Test that repeated accelerators are processed or ignored depending on the
+// commands that they refer to. The behavior for different commands is dictated
+// by chrome::IsCommandRepeatable() in
+// chrome/browser/ui/views/accelerator_table.h.
+TEST_F(BrowserViewTest, RepeatedAccelerators) {
+  // A non-repeated Ctrl-L accelerator should be processed.
+  const ui::Accelerator kLocationAccel(ui::VKEY_L, ui::EF_CONTROL_DOWN);
+  EXPECT_TRUE(browser_view()->AcceleratorPressed(kLocationAccel));
+
+  // If the accelerator is repeated, it should be ignored.
+  const ui::Accelerator kLocationRepeatAccel(
+      ui::VKEY_L, ui::EF_CONTROL_DOWN | ui::EF_IS_REPEAT);
+  EXPECT_FALSE(browser_view()->AcceleratorPressed(kLocationRepeatAccel));
+
+  // A repeated Ctrl-Tab accelerator should be processed.
+  const ui::Accelerator kNextTabRepeatAccel(
+      ui::VKEY_TAB, ui::EF_CONTROL_DOWN | ui::EF_IS_REPEAT);
+  EXPECT_TRUE(browser_view()->AcceleratorPressed(kNextTabRepeatAccel));
+}
+
 class BrowserViewHostedAppTest : public TestWithBrowserView {
  public:
   BrowserViewHostedAppTest() : TestWithBrowserView(Browser::TYPE_POPUP, true) {}
   ~BrowserViewHostedAppTest() override {}
 
  private:
   DISALLOW_COPY_AND_ASSIGN(BrowserViewHostedAppTest);
 };
 
 // Test basic layout for hosted apps.
@@ skipping 22 matching lines @@
       header_offset.y();
 
   // The web contents should be flush with the bottom of the header.
   EXPECT_EQ(bottom_of_header, contents_container->y());
 
   // The find bar should overlap the 1px header/web-contents separator at the
   // bottom of the header.
   EXPECT_LT(browser_view()->GetFindBarBoundingBox().y(),
             browser_view()->frame()->GetTopInset(false));
 }