Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Side by Side Diff: chrome/browser/ui/views/frame/browser_view.h

Issue 2128243003: Make most browser accelerators not repeat. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_
6 #define CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_ 6 #define CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_
7 7
8 #include <map> 8 #include <map>
9 #include <memory> 9 #include <memory>
10 #include <string> 10 #include <string>
(...skipping 634 matching lines...) Expand 10 before | Expand all | Expand 10 after
645 views::View* contents_container_; 645 views::View* contents_container_;
646 646
647 // Tracks and stores the last focused view which is not the 647 // Tracks and stores the last focused view which is not the
648 // devtools_web_view_ or any of its children. Used to restore focus once 648 // devtools_web_view_ or any of its children. Used to restore focus once
649 // the devtools_web_view_ is hidden. 649 // the devtools_web_view_ is hidden.
650 std::unique_ptr<views::ExternalFocusTracker> devtools_focus_tracker_; 650 std::unique_ptr<views::ExternalFocusTracker> devtools_focus_tracker_;
651 651
652 // The Status information bubble that appears at the bottom of the window. 652 // The Status information bubble that appears at the bottom of the window.
653 std::unique_ptr<StatusBubbleViews> status_bubble_; 653 std::unique_ptr<StatusBubbleViews> status_bubble_;
654 654
655 // A mapping between accelerators and commands. 655 // A mapping between accelerators and command IDs.
656 std::map<ui::Accelerator, int> accelerator_table_; 656 std::map<ui::Accelerator, int> accelerator_table_;
657 657
658 // IDs of commands that should be executed in response to repeated
659 // accelerators (i.e. generated by holding keys down). Repeated accelerators
660 // are ignored otherwise.
661 std::set<int> repeatable_command_ids_;
662
658 // True if we have already been initialized. 663 // True if we have already been initialized.
659 bool initialized_; 664 bool initialized_;
660 665
661 // True if we're currently handling a theme change (i.e. inside 666 // True if we're currently handling a theme change (i.e. inside
662 // OnThemeChanged()). 667 // OnThemeChanged()).
663 bool handling_theme_changed_; 668 bool handling_theme_changed_;
664 669
665 // True when in ProcessFullscreen(). The flag is used to avoid reentrance and 670 // True when in ProcessFullscreen(). The flag is used to avoid reentrance and
666 // to ignore requests to layout while in ProcessFullscreen() to reduce 671 // to ignore requests to layout while in ProcessFullscreen() to reduce
667 // jankiness. 672 // jankiness.
(...skipping 30 matching lines...) Expand all
698 // The class that registers for keyboard shortcuts for extension commands. 703 // The class that registers for keyboard shortcuts for extension commands.
699 std::unique_ptr<ExtensionKeybindingRegistryViews> 704 std::unique_ptr<ExtensionKeybindingRegistryViews>
700 extension_keybinding_registry_; 705 extension_keybinding_registry_;
701 706
702 mutable base::WeakPtrFactory<BrowserView> activate_modal_dialog_factory_; 707 mutable base::WeakPtrFactory<BrowserView> activate_modal_dialog_factory_;
703 708
704 DISALLOW_COPY_AND_ASSIGN(BrowserView); 709 DISALLOW_COPY_AND_ASSIGN(BrowserView);
705 }; 710 };
706 711
707 #endif // CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_ 712 #endif // CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698