Fixes bug in scoping for generic methods.

Fixes bug in scoping for generic methods.

The updates to tests/language/generic_local_functions_test.dart use a
local function type argument in its return type, which had not been
tested and did not work.

After a bunch of attempts to change the order in which the resolution
is performed, it suddenly turned out that the offending statement
`visit(node.returnType)` in `ResolverVisitor.visitFunctionExpression`
might be redundant! (.. a subsequent re-resolution in
`ResolverVisitor.analyze` performs the same job, and uses the correct
scope).

So this CL simply removes that `visit..` statement, and the resulting
`dart2js` passes all tests.

Adresses issue https://github.com/dart-lang/sdk/issues/26805.

R=johnniwinther@google.com

Committed: https://github.com/dart-lang/sdk/commit/6942e0df631ee41ae96f330902c777a1248c5cb5

[eernst, 2016-07-07 13:12:59]

eernst@google.com changed reviewers:
+ johnniwinther@google.com

[eernst, 2016-07-07 13:13:00]

It looks like local functions have had their return types double-checked for a
while! So I just removed the traversal that failed (i.e., the one that doesn't
get the right scoping), which seems to resolve 28605, and doesn't break any
tests (the big test run of >17000 test files has reached 8500 without issues,
and all the specific tests run).

So can you see any reasons why that `visit(node.returnType)` would not be
redundant in some corner case?

[Johnni Winther, 2016-07-08 07:38:26]

LGTM

It was redundant!

[eernst, 2016-07-08 11:28:46]

Description was changed from

==========
Fixes bug in scoping for generic methods.

The updates to tests/language/generic_local_functions_test.dart use a
local function type argument in its return type, which had not been
tested and did not work.

After a bunch of attempts to change the order in which the resolution
is performed, it suddenly turned out that the offending statement
`visit(node.returnType)` in `ResolverVisitor.visitFunctionExpression`
might be redundant! (.. a subsequent re-resolution in
`ResolverVisitor.analyze` performs the same job, and uses the correct
scope).

So this CL simply removes that `visit..` statement, and the resulting
`dart2js` passes all tests.

Adresses issue https://github.com/dart-lang/sdk/issues/26805.
==========

to

==========
Fixes bug in scoping for generic methods.

The updates to tests/language/generic_local_functions_test.dart use a
local function type argument in its return type, which had not been
tested and did not work.

After a bunch of attempts to change the order in which the resolution
is performed, it suddenly turned out that the offending statement
`visit(node.returnType)` in `ResolverVisitor.visitFunctionExpression`
might be redundant! (.. a subsequent re-resolution in
`ResolverVisitor.analyze` performs the same job, and uses the correct
scope).

So this CL simply removes that `visit..` statement, and the resulting
`dart2js` passes all tests.

Adresses issue https://github.com/dart-lang/sdk/issues/26805.

R=johnniwinther@google.com

Committed:
https://github.com/dart-lang/sdk/commit/6942e0df631ee41ae96f330902c777a1248c5cb5
==========

[eernst, 2016-07-08 11:28:48]

Committed patchset #1 (id:1) manually as
6942e0df631ee41ae96f330902c777a1248c5cb5 (presubmit successful).