Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2128233002: [Interpreter] Add ClassOf intrinsic. (Closed)

Created:
4 years, 5 months ago by rmcilroy
Modified:
4 years, 5 months ago
Reviewers:
epertoso
CC:
oth, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Add ClassOf intrinsic. BUG=v8:4280 Committed: https://crrev.com/4f2d37da0c74ead265155d2f287b1c92565984dd Cr-Commit-Position: refs/heads/master@{#37637}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -2 lines) Patch
M src/code-stub-assembler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/code-stub-assembler.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M src/interpreter/interpreter-intrinsics.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/interpreter/interpreter-intrinsics.cc View 2 chunks +62 lines, -2 lines 0 comments Download
M test/cctest/interpreter/test-interpreter-intrinsics.cc View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2128233002/1
4 years, 5 months ago (2016-07-07 12:52:03 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-07 13:24:28 UTC) #4
rmcilroy
Enrico, PTAL, thanks.
4 years, 5 months ago (2016-07-07 16:16:00 UTC) #6
rmcilroy
On 2016/07/07 16:16:00, rmcilroy wrote: > Enrico, PTAL, thanks. Ping?
4 years, 5 months ago (2016-07-11 10:50:00 UTC) #7
epertoso
lgtm
4 years, 5 months ago (2016-07-11 10:58:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2128233002/1
4 years, 5 months ago (2016-07-11 11:14:43 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-11 11:45:30 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 11:48:30 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4f2d37da0c74ead265155d2f287b1c92565984dd
Cr-Commit-Position: refs/heads/master@{#37637}

Powered by Google App Engine
This is Rietveld 408576698