Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 2128183002: Make ChannelHandle::socket optional in mus' ChannelHandle mojom. (Closed)

Created:
4 years, 5 months ago by Anand Mistry (off Chromium)
Modified:
4 years, 5 months ago
Reviewers:
Peng, dcheng
CC:
chromium-reviews, rjkroege, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make ChannelHandle::socket optional in mus' ChannelHandle mojom. This case is already supported by the type converter, but a dchecks build will fail with a validation error if this is ever the case. When GPU channels use ChannelMojo, this will be the case 100% of the time. BUG=604282 Committed: https://crrev.com/8fcab50ecd01fcde3d70b2b05fdeef528249af1c Cr-Commit-Position: refs/heads/master@{#404078}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M services/ui/public/interfaces/channel_handle.mojom View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Anand Mistry (off Chromium)
See test failures in https://codereview.chromium.org/2127693002/ (i.e. https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/258199) for the motivation behind this change.
4 years, 5 months ago (2016-07-07 03:23:36 UTC) #2
dcheng
lgtm
4 years, 5 months ago (2016-07-07 03:25:18 UTC) #3
Peng
On 2016/07/07 03:25:18, dcheng wrote: > lgtm lgtm
4 years, 5 months ago (2016-07-07 03:40:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2128183002/1
4 years, 5 months ago (2016-07-07 03:41:50 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-07 04:56:16 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 04:56:18 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 04:58:03 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8fcab50ecd01fcde3d70b2b05fdeef528249af1c
Cr-Commit-Position: refs/heads/master@{#404078}

Powered by Google App Engine
This is Rietveld 408576698