components/safe_browsing_db/v4_database_unittest.cc - Issue 2128173003: Merge the hash prefixes from the old store and the additions in the partial

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/safe_browsing_db/v4_database_unittest.cc

Issue 2128173003: Merge the hash prefixes from the old store and the additions in the partial (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Simplified merge logic. +Nit: Fix a failing test Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/safe_browsing_db/v4_database_unittest.cc

diff --git a/components/safe_browsing_db/v4_database_unittest.cc b/components/safe_browsing_db/v4_database_unittest.cc

index 2dee2a6628de72c77498d87c39b3009c15f7979e..7d216ad90070ec87c0df936394c045c42b78aa66 100644

--- a/components/safe_browsing_db/v4_database_unittest.cc

+++ b/components/safe_browsing_db/v4_database_unittest.cc

@@ -133,6 +133,7 @@ class V4DatabaseTest : public PlatformTest {

for (const auto& store_state_iter : store_state_map) {

UpdateListIdentifier identifier = store_state_iter.first;

ListUpdateResponse* list_update_response = new ListUpdateResponse;

+ list_update_response->set_response_type(ListUpdateResponse::FULL_UPDATE);

list_update_response->set_platform_type(identifier.platform_type);

list_update_response->set_threat_entry_type(identifier.threat_entry_type);

list_update_response->set_threat_type(identifier.threat_type);

« no previous file with comments | « no previous file | components/safe_browsing_db/v4_store.h » ('j') | components/safe_browsing_db/v4_store.cc » ('J')