Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2128163002:
Roll PDFium cfb31d6..2f6d148 (Closed)
|
Created:
4 years, 5 months ago by Oliver Chang Modified:
4 years, 5 months ago Reviewers:
Lei Zhang CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRoll PDFium cfb31d6..2f6d148
https://pdfium.googlesource.com/pdfium.git/+log/cfb31d6..2f6d148
BUG=625541, 625823
Committed: https://crrev.com/95adc31201fd4d1f3b9ec96a62993e64d3273ed9
Cr-Commit-Position: refs/heads/master@{#404047}
Patch Set 1 #Messages
Total messages: 16 (7 generated)
Description was changed from ========== Roll PDFium cfb31d6..2f6d148 https://pdfium.googlesource.com/pdfium.git/+log/cfb31d6..2f6d148 BUG=625541,625823 TEST=bots ========== to ========== Roll PDFium cfb31d6..2f6d148 https://pdfium.googlesource.com/pdfium.git/+log/cfb31d6..2f6d148 BUG=625541,625823 ==========
ochang@chromium.org changed reviewers: + thestig@chromium.org
TBR
The CQ bit was checked by ochang@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
lgtm, need to write TBR=
On 2016/07/07 00:36:24, Lei Zhang wrote: > lgtm, need to write TBR= oops, thanks.
The CQ bit was checked by ochang@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Roll PDFium cfb31d6..2f6d148 https://pdfium.googlesource.com/pdfium.git/+log/cfb31d6..2f6d148 BUG=625541,625823 ========== to ========== Roll PDFium cfb31d6..2f6d148 https://pdfium.googlesource.com/pdfium.git/+log/cfb31d6..2f6d148 BUG=625541,625823 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Roll PDFium cfb31d6..2f6d148 https://pdfium.googlesource.com/pdfium.git/+log/cfb31d6..2f6d148 BUG=625541,625823 ========== to ========== Roll PDFium cfb31d6..2f6d148 https://pdfium.googlesource.com/pdfium.git/+log/cfb31d6..2f6d148 BUG=625541,625823 Committed: https://crrev.com/95adc31201fd4d1f3b9ec96a62993e64d3273ed9 Cr-Commit-Position: refs/heads/master@{#404047} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/95adc31201fd4d1f3b9ec96a62993e64d3273ed9 Cr-Commit-Position: refs/heads/master@{#404047} |
