Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(946)

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js

Issue 2128133002: Timeline AddTraceProvider API Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js
diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js
index 3ce1bc2a3b2d5eb85e22af33d1ca022a59eb61d4..3836bb77600ac7d69daa16f0cfca0a0dcdb184c4 100644
--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js
+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js
@@ -18,6 +18,7 @@ WebInspector.TimelineController = function(target, delegate, tracingModel)
this._targets = [];
this._allProfilesStoppedPromise = Promise.resolve();
this._targetsResumedPromise = Promise.resolve();
+ this._extensionTraceProviders = WebInspector.extensionServer.traceProviders();
WebInspector.targetManager.observeTargets(this);
}
@@ -67,6 +68,10 @@ WebInspector.TimelineController.prototype = {
if (captureFilmStrip)
categoriesArray.push(disabledByDefault("devtools.screenshot"));
+ for (var traceProvider of this._extensionTraceProviders) {
caseq 2016/07/08 00:57:49 nit: drop redundant {}
+ traceProvider.run();
+ }
+
var categories = categoriesArray.join(",");
this._startRecordingWithCategories(categories, enableJSSampling);
},
@@ -77,6 +82,12 @@ WebInspector.TimelineController.prototype = {
this._target.tracingManager.stop();
this._targetsResumedPromise = WebInspector.targetManager.resumeAllTargets();
this._delegate.loadingStarted();
+
+ var target = WebInspector.targetManager.mainTarget();
+ var requests = target.networkLog.requests().slice();
caseq 2016/07/08 00:57:49 Why are we doing this? This does not look good.
+ for (var traceProvider of this._extensionTraceProviders) {
+ traceProvider.stop(requests);
+ }
},
/**

Powered by Google App Engine
This is Rietveld 408576698