Timeline AddTraceProvider API

third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @constructor
  * @param {!WebInspector.Target} target
  * @param {!WebInspector.TimelineLifecycleDelegate} delegate
  * @param {!WebInspector.TracingModel} tracingModel
  * @implements {WebInspector.TargetManager.Observer}
  * @implements {WebInspector.TracingManagerClient}
  */
 WebInspector.TimelineController = function(target, delegate, tracingModel)
 {
     this._delegate = delegate;
     this._target = target;
     this._tracingModel = tracingModel;
     this._targets = [];
     this._allProfilesStoppedPromise = Promise.resolve();
     this._targetsResumedPromise = Promise.resolve();
+    this._extensionTraceProviders = WebInspector.extensionServer.traceProviders();
     WebInspector.targetManager.observeTargets(this);
 }
 
 WebInspector.TimelineController.prototype = {
     /**
      * @param {boolean} captureCauses
      * @param {boolean} enableJSSampling
      * @param {boolean} captureMemory
      * @param {boolean} capturePictures
      * @param {boolean} captureFilmStrip
@@ skipping 29 matching lines @@
         if (captureCauses && Runtime.experiments.isEnabled("timelineInvalidationTracking"))
             categoriesArray.push(disabledByDefault("devtools.timeline.invalidationTracking"));
         if (capturePictures) {
             categoriesArray.push(disabledByDefault("devtools.timeline.layers"),
                                  disabledByDefault("devtools.timeline.picture"),
                                  disabledByDefault("blink.graphics_context_annotations"));
         }
         if (captureFilmStrip)
             categoriesArray.push(disabledByDefault("devtools.screenshot"));
 
+        for (var traceProvider of this._extensionTraceProviders) {

[caseq, 2016/07/08 00:57:49]

nit: drop redundant {}

+            traceProvider.run();
+        }
+
         var categories = categoriesArray.join(",");
         this._startRecordingWithCategories(categories, enableJSSampling);
     },
 
     stopRecording: function()
     {
         this._allProfilesStoppedPromise = this._stopProfilingOnAllTargets();
         this._target.tracingManager.stop();
         this._targetsResumedPromise = WebInspector.targetManager.resumeAllTargets();
         this._delegate.loadingStarted();
+
+        var target = WebInspector.targetManager.mainTarget();
+        var requests = target.networkLog.requests().slice();

[caseq, 2016/07/08 00:57:49]

Why are we doing this? This does not look good.

+        for (var traceProvider of this._extensionTraceProviders) {
+            traceProvider.stop(requests);
+        }
     },
 
     /**
      * @override
      * @param {!WebInspector.Target} target
      */
     targetAdded: function(target)
     {
         this._targets.push(target);
         if (this._profiling)
@@ skipping 186 matching lines @@
 
     /**
      * @param {number} progress
      * @override
      */
     eventsRetrievalProgress: function(progress)
     {
         this._delegate.loadingProgress(progress);
     }
 }