Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/extensions/ExtensionTraceProvider.js

Issue 2128133002: Timeline AddTraceProvider API Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 /**
2 * @constructor
3 * @param {string} extensionOrigin
4 * @param {string} id
5 * @param {string} categoryName
6 * @param {string} categoryTooltip
7 */
8 WebInspector.ExtensionTraceProvider = function(extensionOrigin, id, categoryName , categoryTooltip)
9 {
10 this._extensionOrigin = extensionOrigin;
11 this._id = id;
12 this._categoryName = categoryName;
13 this._categoryTooltip = categoryTooltip;
14 }
15
16 WebInspector.ExtensionTraceProvider.prototype = {
17 get id()
caseq 2016/07/08 00:57:49 It doesn't look like we have to expose id external
18 {
19 return this._id;
20 },
caseq 2016/07/08 00:57:49 add blank lines after all methods.
21 get categoryName()
caseq 2016/07/08 00:57:49 please add @return annotations. Also, no getters i
22 {
23 return this._categoryName;
24 },
25 get categoryTooltip()
26 {
27 return this._categoryTooltip;
28 },
29 run: function()
caseq 2016/07/08 00:57:49 s/run/start/
30 {
31 WebInspector.extensionServer.startTraceRecording(this.id);
32 },
33 /**
34 * @param {!Array.<!WebInspector.NetworkRequest>} requests
caseq 2016/07/08 00:57:49 nit: Array<!WebInspector.NetworkRequest>
35 */
36 stop: function(requests)
37 {
38 WebInspector.extensionServer.stopTraceRecording(this.id);
39 }
40 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698