Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4693)

Unified Diff: cc/test/pixel_test.cc

Issue 2128113002: Use a cc::Display for WebView resourceless software draws. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: displaywebview: mojom Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/test/pixel_test.h ('k') | cc/trees/layer_tree_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/test/pixel_test.cc
diff --git a/cc/test/pixel_test.cc b/cc/test/pixel_test.cc
index b20ef02cb861a02978dc3d5dc14b91a090a27e7b..13fc91959a799066702aa5f61880f7e8f38cc647 100644
--- a/cc/test/pixel_test.cc
+++ b/cc/test/pixel_test.cc
@@ -80,10 +80,15 @@ bool PixelTest::RunPixelTestWithReadbackTargetAndArea(
gfx::Rect device_clip_rect = external_device_clip_rect_.IsEmpty()
? device_viewport_rect
: external_device_clip_rect_;
+
+ if (software_renderer_) {
+ software_renderer_->SetDisablePictureQuadImageFiltering(
+ disable_picture_quad_image_filtering_);
+ }
+
renderer_->DecideRenderPassAllocationsForFrame(*pass_list);
renderer_->DrawFrame(pass_list, device_scale_factor, gfx::ColorSpace(),
- device_viewport_rect, device_clip_rect,
- disable_picture_quad_image_filtering_);
+ device_viewport_rect, device_clip_rect);
// Wait for the readback to complete.
if (output_surface_->context_provider())
@@ -182,9 +187,11 @@ void PixelTest::SetUpSoftwareRenderer() {
main_thread_task_runner_.get(), 0, 1, delegated_sync_points_required,
settings_.renderer_settings.use_gpu_memory_buffer_resources,
settings_.use_image_texture_targets);
- renderer_ = SoftwareRenderer::Create(
- this, &settings_.renderer_settings, output_surface_.get(),
- resource_provider_.get(), true /* use_image_hijack_canvas */);
+ std::unique_ptr<SoftwareRenderer> renderer =
+ SoftwareRenderer::Create(this, &settings_.renderer_settings,
+ output_surface_.get(), resource_provider_.get());
+ software_renderer_ = renderer.get();
+ renderer_ = std::move(renderer);
}
} // namespace cc
« no previous file with comments | « cc/test/pixel_test.h ('k') | cc/trees/layer_tree_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698