Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3807)

Unified Diff: cc/output/compositor_frame_metadata.h

Issue 2128113002: Use a cc::Display for WebView resourceless software draws. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: displaywebview: mojom Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/ipc/struct_traits_unittest.cc ('k') | cc/output/compositor_frame_metadata.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/output/compositor_frame_metadata.h
diff --git a/cc/output/compositor_frame_metadata.h b/cc/output/compositor_frame_metadata.h
index c2e13fe6e3fc91b8ec7d64ebfa180376b54143f7..d6f0e60a490ddd8b25586ef7414a84f949021fc2 100644
--- a/cc/output/compositor_frame_metadata.h
+++ b/cc/output/compositor_frame_metadata.h
@@ -31,21 +31,27 @@ class CC_EXPORT CompositorFrameMetadata {
CompositorFrameMetadata Clone() const;
// The device scale factor used to generate this compositor frame.
- float device_scale_factor;
+ float device_scale_factor = 0.f;
// Scroll offset and scale of the root layer. This can be used for tasks
// like positioning windowed plugins.
gfx::Vector2dF root_scroll_offset;
- float page_scale_factor;
+ float page_scale_factor = 0.f;
// These limits can be used together with the scroll/scale fields above to
// determine if scrolling/scaling in a particular direction is possible.
gfx::SizeF scrollable_viewport_size;
gfx::SizeF root_layer_size;
- float min_page_scale_factor;
- float max_page_scale_factor;
- bool root_overflow_x_hidden;
- bool root_overflow_y_hidden;
+ float min_page_scale_factor = 0.f;
+ float max_page_scale_factor = 0.f;
+ bool root_overflow_x_hidden = false;
+ bool root_overflow_y_hidden = false;
+
+ // WebView makes quality decisions for rastering resourceless software frames
+ // based on information that a scroll or animation is active.
+ // TODO(aelias): Remove this and always enable filtering if there aren't apps
+ // depending on this anymore.
+ bool is_resourceless_software_draw_with_scroll_or_animation = false;
// Used to position the Android location top bar and page content, whose
// precise position is computed by the renderer compositor.
@@ -55,7 +61,7 @@ class CC_EXPORT CompositorFrameMetadata {
// This color is usually obtained from the background color of the <body>
// element. It can be used for filling in gutter areas around the frame when
// it's too small to fill the box the parent reserved for it.
- SkColor root_background_color;
+ SkColor root_background_color = SK_ColorWHITE;
// Provides selection region updates relative to the current viewport. If the
// selection is empty or otherwise unused, the bound types will indicate such.
« no previous file with comments | « cc/ipc/struct_traits_unittest.cc ('k') | cc/output/compositor_frame_metadata.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698